games crash upon Achievement Watcher toast notification when disable_overlay.txt is enabled

[turusudiro]

tried with Speedrunners and Warriors Orochi 4 everytime achievement unlocked and a toast notification appear it will instantly crash the game. This issue occurs only when the 'disable_overlay.txt' file is present. However, using 'disable_overlay_achievement_notification.txt' resolves the problem.

[otavepto]

This is weird, disable_overlay.txt will prevent even the renderer detector from initializing. Which release are you using ? Does this happen on older builds or even the original emu ? Also logs will help, please post them.

I suspect it's this line if the game tried to post a notification forcefully without first checking for Ready() (overlay API) https://github.com/otavepto/gbe_fork/blob/d4485350212bea5d709d3b63802ade04c784b563/overlay_experimental/steam_overlay.cpp#L1461-L1465

[turusudiro]

I'm using the latest release. I dont test it yet using original emu, but where's the log exactly? im using ColdClientLoader.

[turusudiro]

This is exactly what happened when using disable_overlay.txt

https://github.com/otavepto/gbe_fork/assets/93848801/f84f6400-aad9-41bd-b1a1-5a4dcbffc805

And this is without disable_overlay.txt and with disable_overlay_achievement_notification.txt

https://github.com/otavepto/gbe_fork/assets/93848801/12013988-eb42-4cdf-9a78-83ff00e8ffaa

[otavepto]

You have to use the debug build, it produces a file called STEAM_LOG.txt. I've posted a hotfix, I'd appreciate if you'd test it when you have time: https://github.com/otavepto/gbe_fork/actions/runs/8211307943

Once Github finishes, you'll be able to download the build, it takes ~20 min.

[otavepto]

It's done, once you confirm this worked for you I'll post another release with this hotfix

[turusudiro]

Unfortunately it still crash, also it doesnt create any log with https://github.com/otavepto/gbe_fork/actions/runs/8211307943 debug release? i've been looking in Steam folder, the ColdClientLoader folder and the games folder i cant find it anywhere...

[CHESIRE721]

@otavepto I got the game and generated the log so you can check the overlay problem when opening the game without the disable_overlay.txt file. STEAM_LOG.txt

[turusudiro]

Hey, just find out that im not replace my old steamclient.dll with this release lol for some reason sorry.

You have to use the debug build, it produces a file called STEAM_LOG.txt. I've posted a hotfix, I'd appreciate if you'd test it when you have time: https://github.com/otavepto/gbe_fork/actions/runs/8211307943

Once Github finishes, you'll be able to download the build, it takes ~20 min.

after using this release, the games worked fine with disable_overlay.txt and notification appear without crashing the game i guess its fixed. Maybe you should release this hotfix for users like me using AW and disable_overlay.txt.

[otavepto]

Creating a hotfix release right away. Thanks everyone for reporting this earlier and the logs, it's indeed crashing after resizing the image and attempting to push it as a resource for the renderer hook, which shouldn't happen if the overlay was disabled in the first place.