No Updated Data in Node Red from Smartthings Thermostats

burtonjk commented 4 years ago

First of all - awesome solution, has been really useful for me, thank you for the great work.

Not exactly sure when this started happening, but it was all working correctly when I first installed late last year. I can't be sure it is limited to Thermostats, but that is where my issue lies at the moment.

The issue is that a change to the Thermostat in the ST app triggers an event in Node Red but the data sent from the Thermostat node is the same as it was on deploy of the flow. IE. it never changes.

The screenshot from Node Red below is the result of me changing the set temperature 3 times, from 21 down to 18. You can see it always reports as 20

I do have the required devices set in the SmartApp configuration and when I run the simulator for the SmartApp, I get the error as below:

Screenshot 2020-05-11 at 15 14 10

My Version of node-red-contrib-smartthings is 0.0.20

Hope you can help with this

cspawn1 commented 4 years ago

Hi there our two issues might be related. Can you share your flow? or maybe just what you are injecting into the thermostat node to try and updated the heatingSetpoint?

burtonjk commented 4 years ago

I think you are correct and our 2 issues are more than likely related.

However, my problem is not to do with updating the heatingSetpoint by injecting a value - that works fine and my code to inject is:

var msg = { topic: "heatingSetpoint", payload: { "value": msg.payload.TargetTemperature } } return msg;

My problem is that when changing the heatingSetpoint from the thermostat in the Smartthings app or indeed from the physical thermostat, the Node-Red thermostat doesn't update, it simply repeats the previously set value (hope that makes sense)

So in my flow as shown below, I can successfully change the heatingSetpoint by adjusting the Heating South (Apple Homekit) node, but changes initiated by Smartthings are not reflected in the flow. As I say, the trigger occurs, but the value doesn't change.

Hope we can work together to solve our respective issues.

cspawn1 commented 4 years ago

burtonjk - sorry for the delay in updating. I have been working on this project on an inconsistent basis.

I can confirm the same findings as you. It seems like none of the Thermostat Node outputs are updating (except for the current temperature) if the setpoints or thermostatMode/fanModes are adjusted via the thermostat itself (or via the TCC web portal).

Seems like it is something in the nodes code that need to be fixed....

I have gotten around this issue for now by locking all our buildings thermostats. This works OK in my case since occupants shouldn't be adjusting temperatures anyway.

Derek-st commented 2 years ago

A little more info. I took the liberty of catching the webhook POST. It correctly reflects changes. (In my case I'm interested in keeping track of OperatingState so grabbed one of those)

{\x22id\x22:\x225b009a71-7770-4cb7-b888-9e6259432d85\x22,\x22date\x22:\x222021-11-30T19:04:44.257Z\x22,\x22value\x22:\x22idle\x22,\x22name\x22:\x22thermostatOperatingState\x22,\x22display_name\x22:\x22Radient thermostat\x22,\x22description\x22:\x22Radient thermostat thermostat operating state is idle\x22,\x22source\x22:\x22DEVICE\x22,\x22state_changed\x22:true,\x22physical\x22:false,\x22location_id\x22:\x22blah blah\x22,\x22hub_id\x22:\x22blah blah\x22}

same message at the output of the thermostat node: - Note the value is stuck at heating. A new Deploy needed to change that

11/30/2021, 2:04:44 PMnode: 3e803164cea4b821 device : msg.payload : Object object deviceId: "5b009a71-7770-4cb7-b888-9e6259432d85" deviceType: "thermostatOperatingState" name: "Radient thermostat(thermostatOperatingState)" value: "heating"

Derek-st commented 2 years ago

... and a bread crumb for someone who can maintain this

Line 192 in "smartthings-thermostat.js

  switch(evt["name"].toLowerCase()){               "Converts the comparison to lowercase...

but the values in the switch are camel case.

e.g. case "coolingSetpoint":

Changing all of the values in case quotes to lower case will do the trick.

otaviojr / node-red-contrib-smartthings

No Updated Data in Node Red from Smartthings Thermostats #35