otavioschwanck / arrow.nvim

Bookmark your files, separated by project, and quickly navigate through them.
Other
454 stars 19 forks source link

No support for directories? #12

Closed mblarsen closed 6 months ago

mblarsen commented 7 months ago

Expected behavior

api . modules
api . development/eu-central-1
api . production/eu-central-1

Actual behavior

. modules/api
. development/eu-central-1/api
. production/eu-central-1/api

I'm guessing the name that matches is no name and then it puts the paths as qualifier for that.

Aside from the rendering issue it works fine with directories. (in my case paired with oil.nvim)

image
otavioschwanck commented 6 months ago

Expected behavior

api . modules
api . development/eu-central-1
api . production/eu-central-1

Actual behavior

. modules/api
. development/eu-central-1/api
. production/eu-central-1/api

I'm guessing the name that matches is no name and then it puts the paths as qualifier for that.

Aside from the rendering issue it works fine with directories. (in my case paired with oil.nvim)

image

i will add the support for directories later in the week

otavioschwanck commented 6 months ago

Done at https://github.com/otavioschwanck/arrow.nvim/commit/2bfe485b483ac2aaefe91fb1ab793e13918f13e0

image

mblarsen commented 6 months ago

That was fast :D

Any reason why not applying the same "duplicate" name logic as for files? I.e. when two directory names are the same show . parent/path.

api . modules
api . development/eu-central-1
api . production/eu-central-1
image
otavioschwanck commented 6 months ago

That was fast :D

Any reason why not applying the same "duplicate" name logic as for files? I.e. when two directory names are the same show . parent/path.

api . modules
api . development/eu-central-1
api . production/eu-central-1
image

you think that logic makes sense? i will do it

otavioschwanck commented 6 months ago

Done:

image

mblarsen commented 6 months ago

Really nice, thanks a lot <3