Closed sQVe closed 5 months ago
Good plugin, but same issue.
Hey, 👋
Most importantly, thank you for you an excellent plugin! ❤️
I'm trying to separate my bookmarks between branches, and having troubles getting it to work. Setting the
separate_by_branch
option to eitherfalse
ortrue
does nothing.🍻
how did you setup arrow?
could you try to run inside a project in neovim:
:lua = require("arrow.git").get_git_branch()
and see if is returning the right branch.
Observation: if you are using some session manager, it can mess arrow. Check:
https://github.com/otavioschwanck/arrow.nvim?tab=readme-ov-file#working-with-sessions-plugins
@otavioschwanck I'm guessing the issue may be due to this line. It assumes the user's current directory has a .git
subdirectory. However, navigating into any subdirectories of a repo will cause that check to fail. It may be better to use [:h vim.fs.find
](https://neovim.io/doc/user/lua.html#vim.fs.find()) to search for .git
instead. This is what grapple.nvim does.
@otavioschwanck I'm guessing the issue may be due to this line. It assumes the user's current directory has a
.git
subdirectory. However, navigating into any subdirectories of a repo will cause that check to fail. It may be better to use [:h vim.fs.find
](https://neovim.io/doc/user/lua.html#vim.fs.find()) to search for.git
instead. This is what grapple.nvim does.
done: https://github.com/otavioschwanck/arrow.nvim/commit/efad6908abe10d7d74b24c203ad62e51662522a2
@sQVe could you test it?
@otavioschwanck It seems to work consistently now.
The issue was a bit weird before - something it worked, and sometimes not. Seems like it should be related to the issue mentioned by @cbochs.
Wow, that was quick. It works well now. Thank you!
Hey, 👋
Most importantly, thank you for you an excellent plugin! ❤️
I'm trying to separate my bookmarks between branches, and having troubles getting it to work. Setting the
separate_by_branch
option to eitherfalse
ortrue
does nothing.🍻