otavioschwanck / arrow.nvim

Bookmark your files, separated by project, and quickly navigate through them.
Other
341 stars 16 forks source link

Feat/per buffer use extmark to track lines #36

Closed xzbdmw closed 3 months ago

xzbdmw commented 3 months ago

This track system works nicely thanks to extmarks's tracking nature, it is really complicated in vscode to track bookmarks lines. Some ideas:

  1. When users select bookmarks, their eyes are usually placed on the cursor line, so highlighting the cursor position like portal may be a better choice.
  2. We can add a setting to automatically add the current file when adding a bookmark(if the file does not added yet), and show bookmarks numbers after filenames, then it becomes a natural tree representation.
  3. The window layout may be more intelligent. If there is not enough space, compress the width and display two columns. If it is even not enough, compress the height.
  4. Window title maybe can used for displaying a note(though I'm lazy to add notes).

It works very good by far, and IMO better than other bookmark plugins which typically use Telescope to select entries, there are no syntax highlighting at a glance and have more mental overhead, that's why users choose arrow instead of fuzzy find files😓

otavioschwanck commented 3 months ago

i did not have time this weekend because of holidays, i will review this during the week. Thanks!

otavioschwanck commented 3 months ago

Awesome PR! This weekend i will finish the feature and release!