search

otetard / ownpad

Ownpad is a Nextcloud application that allows to create and open Etherpad and Ethercalc documents.
GNU Affero General Public License v3.0
58 stars 25 forks source link

Multi-sheet-support for ethercalc breaks ownpad-ethercalc #66

Closed laryllian closed 1 year ago

laryllian commented 6 years ago

Dear otetard and crew, thanks so much for this helpful nc-app. I love it. :D

But here is my problem, maybe you can help: Multi-sheet-support for ethercalc breaks ownpad-ethercalc on my instance. Whenever I create a table with the "+" and choose "Calc", a table is created, but the intended "=" sign in the link becomes "%3D", such as in https://domain.org/calc/%3DKH79P35Vf...

Ethercalc however cannot process this "percentage-link" and in effect always shows the same table regardless of the actual link. My workaround is changing the file "lib/Service/OwnpadService.php" on line 40.

Old line (with multi-sheet-support ): $url = sprintf("%s/=%s", rtrim($host, "/"), $token);

New line (without multi-sheet-support): $url = sprintf("%s/%s", rtrim($host, "/"), $token);

Now the links work, but the tables naturally only have one sheet. Does anyone know, where this comes from and how I can tackle this to get multi-sheet-support? Thank you

My setup: CentOS 7 with PHP 7.1.20 Nextcloud 13.0.4 Ethercalc 2010-07-05 Ownpad 0.6.8

poVoq commented 6 years ago

This seems to work fine with the newest version of Ethercalc available through dockerhub: https://hub.docker.com/r/audreyt/ethercalc/

otetard commented 1 year ago

I’m closing this issue since this is a very old one. Please open a new issue if you still encounter this issue with the latest version of Ownpad!