search

othiym23 / async-listener

polyfill version of the 0.11 version of the asyncListener API
https://www.npmjs.org/package/async-listener
BSD 2-Clause "Simplified" License
174 stars 52 forks source link

net.connect issue with Node.js 7.10.0 #109

Open watson opened 7 years ago

watson commented 7 years ago

A commit recently landed in Node core that was released as v7.10.0 two days ago.

It breaks async-listener because net.connect no longer calls Socket.prototype.connect. Furthermore, it's not possible to simply monkey-patch net.connect because it's being called internally in node by simply referencing the connect function and not the exports.connect function.

I'm working on fixing this together with @cjihrig and @jasnell. See https://github.com/nodejs/node/pull/12852 for details.

It will most likely be released as v7.10.1.

watson commented 7 years ago

The work to fix this have now been moved to https://github.com/nodejs/node/pull/12861