Allow failures on latest Node 7

othiym23 / async-listener

polyfill version of the 0.11 version of the asyncListener API

https://www.npmjs.org/package/async-listener

BSD 2-Clause "Simplified" License

174 stars 52 forks source link

Allow failures on latest Node 7 #117

Closed watson closed 7 years ago

watson commented 7 years ago

Because issue https://github.com/othiym23/async-listener/issues/109 have not yet been solved for Node.js 7, the test suite currently fails when running on the latest version of Node.js 7 (v7.10.0 as of this commit).

This commit allows 7.x to fail, but adds an extra build for 7.9.0 which is know to be good.

This should be reverted when/if Node.js 7 is patched accordingly.

watson commented 7 years ago

Weird... it seems from the tests that Travis CI is not adhering to the allow_failures setting. Will investigate

watson commented 7 years ago

Apparently the allow_failures logic in the .travis.yml have NEVER worked because it was written incorrectly. I fixed it for both the new version 7, but also for the existing version 3 and 5.

Whether or not we want this for 3 and 5 should be discussed on #116

hayes commented 7 years ago

Looks good to me