search

othiym23 / async-listener

polyfill version of the 0.11 version of the asyncListener API
https://www.npmjs.org/package/async-listener
BSD 2-Clause "Simplified" License
174 stars 52 forks source link

remove support for `crypto.pseudoRandomBytes` in node 11+ #138

Closed vdeturckheim closed 6 years ago

vdeturckheim commented 6 years ago

fixes #137

watson commented 6 years ago

Btw, the work I did to try and fix this previously (but put off because of the Node.js 11 test failures), @Qard and I instead implemented in Elastic APM here: https://github.com/elastic/apm-agent-nodejs/commit/68c5524cfcf5e98a5dce2238d0198ad3b8005c81

vdeturckheim commented 6 years ago

@watson thanks for the review, I just updated this part. I agree with you but if possible I'd rather have a quick publish of this update as this is currently probably blocking large chunks of the instrumentation ecosystem on node 11.

watson commented 6 years ago

I'm ok with merging without adding v11 tests to get this working quickly

vdeturckheim commented 6 years ago

Thanks :D (btw I love suggested changes)

vdeturckheim commented 6 years ago

Shame on me, I have not used node < 4 in years

watson commented 6 years ago

Released in v0.6.10