search

othiym23 / bug-clinic

a nodeschool.io-style workshopper for learning how to debug Node.js apps
https://npmjs.org/package/bug-clinic
BSD 2-Clause "Simplified" License
175 stars 49 forks source link

Multiple little fixes #6

Closed mdda closed 10 years ago

mdda commented 10 years ago

Hope this 'diverse' patchset is Ok : There were a bunch of tiny niggles, on a nodeschool module that was very enjoyable overall.

Many Thanks Martin :-)

othiym23 commented 10 years ago

Wow, this is great! Thanks for the thorough review! Do you mind if I add you as a contributor to the workshopper?

I'll review / squash / merge these changes today. Thank you!

mdda commented 10 years ago

Excellent! It would be great to be added as a contributor to the workshopper.

( As a bit of background : Tim Oxley is organising NodeSchool SG tomorrow, so a bunch of us are running through the different workshops. It's great that you're open to improvements - and I'd be happy to act as 'crash dummy' for any extra lessons you create! )

othiym23 commented 10 years ago

Landed as a squashed commit in b96c6d8cfd83b23ec6749def4f28e983669c5221 and separate contributor credit in 98e9111602bc23111b959ee998ce1c0af490eeb1, published as bug-clinic@1.1.4.

Thanks again, Martin! Good luck tomorrow, and let me know if there are more things you learn from the event!