Open watson opened 7 years ago
The work to fix this have now been moved to https://github.com/nodejs/node/pull/12861
This seems to still be busted as of Node 9 -- is there something we need to do to address this in either async-listener
or CLS?
test/net-events.tap.js
failed, in node8+
this may work: https://github.com/othiym23/async-listener/pull/129, @watson @othiym23, I need some help, thanks!
A commit recently landed in Node core that was released as v7.10.0 two days ago.
It breaks async-listener and therefore also continuation-local-storage because
net.connect
no longer callsSocket.prototype.connect
. Furthermore, it's not possible to simply monkey-patchnet.connect
in async-listener because it's being called internally in node by simply referencing theconnect
function and not theexports.connect
function.I'm working on fixing this together with @cjihrig and @jasnell. See https://github.com/nodejs/node/pull/12852 for details.
It will most likely be released as v7.10.1.
Here's the relevant issue in async-listener: https://github.com/othiym23/async-listener/issues/109