Impact of async_hook on the CLS

othiym23 / node-continuation-local-storage

implementation of https://github.com/joyent/node/issues/5243

BSD 2-Clause "Simplified" License

1.13k stars 207 forks source link

Open vdeturckheim opened 7 years ago

vdeturckheim commented 7 years ago

Hi,

It seems that the async hooks feature will be available soon in Node.js core (https://github.com/nodejs/node/pull/12953).

If a new version of the CLS is made using this features/ what would be the impact?

can the CLS have a double behavior (one if 'async_hooks' is available, and one other)?
will this mean that there will be fewer context loss?

Thanks a lot!

magnusjt commented 7 years ago

I don't know what's happening here, but here is a fork that will use async_hooks: https://github.com/Jeff-Lewis/cls-hooked/issues/4