othmar52 / slimpd

PHP/JS based MPD-web-client for large music collections
GNU Affero General Public License v3.0
41 stars 11 forks source link

weighting of images based on filenames #21

Open killhellokitty opened 8 years ago

killhellokitty commented 8 years ago

Images need to have weight based on their subject. Front/Cover should always be first and may need 'imagemagik' to force size of the object (It should be nessasary to have the app select only one; front, cover, folder. In the event 2 or more are present within the Artist's folder). Back should be second, possibly including digi-packs. And inserts should be last. Its fantastic that you have the capability to show all these images, virtually no media player allows this. For those of who are audiophiles this is a major bonus to maintaining and appreciating our collections.

othmar52 commented 8 years ago

implementing weight will need some configuration which holds common spelling variations. can you create this? for example:

front.1 = cover
front.2 = front

back.1 = back

inlay.1 = booklet

cd.1 = cd

???.1 = 

in case you need some inspiration - here is a list with my image filenames which's count of appearances > 2

othmar52 commented 8 years ago

please pull the latest commits and give it a try.

NOTE: to save performance on all frequent database updates this weightening is only applied during the very first import into sliMpd's database. So the best is to drop the database and recreate it as there also had been some structural database changes.

killhellokitty commented 8 years ago

I'll go ahead and give this a try even though the actual music is unavailable; the images are shown properly at this time. I'm not sure about only having it weighing for the first import. Generally we update the database because we have added new music files to our collection. New files means new images. Maybe it would be best to set the 'update sliMPD database' button on the 'importer' page; instead of doing an update to database, have it do a full reinstall of the database so that all new music added will have weighted images as well. I really would like that button to be the magic button to install and create the database soooooooo bad. ;-)

On Sun, Jul 31, 2016 at 5:55 AM, othmar52 notifications@github.com wrote:

please pull the latest commits https://github.com/othmar52/slimpd/commit/0b287bc2aab4ab6d8126d7e5a58efa13893d8d1a and give it a try.

NOTE: to save performance on all frequent database updates this weightening is only applied during the very first import into sliMpd's database. So the best is to drop the database and recreate it as there also had been some structural database changes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-236423545, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslVLJB6lr9ZF-RWJ0EQafe9BK4PHDks5qbH8RgaJpZM4JTnt3 .

othmar52 commented 8 years ago

of course the image weightening for new files will be applied without recreating the whole slimpd database. But yes, the mentioned button would really be a helpful feature.

killhellokitty commented 8 years ago

They are kinda strangely placed. For example #1 is a digipack so the first image is the front-side of the digipack; which stretches from back-to-front as a single image. Next, is the actual Front/cover image, next is one of the inside/insert pages (not the first one, but somewhere in between) the reason this would matter is if you want to read the information within the booklet it is spread throughout the other images and cd-images in no readable order. Cd-images - disk1 is in the middle of all the images and disk2 is near the last image. They should be probably be the last image next to each other at the very end of the list.

2 has the first image as the first inner-sleeve (open fold) larger sized

than the rest of the images (This is great, the size is what I am speaking of. The first image should be larger. It should also be the front/cover the image that we instantly recognize the album by). The next image is the Front/Cover and the next after that is the Front/Cover again! Duplicates! Then we have the back-cover, and then the last page of the insert/sleeve. Then we have the first inner-sleeve image again! Cd-image is next, then the second page/insert/sleeve, and then finally the back (single side or closed sleeve) backside image.

So I guess I would have to say that at this point the weighting is a failure. The front/cover (only one copy of the image should be displayed) Should be first and larger than the other images. Next/in-place-of, would be digipack-front/cover image (This would really be the first image as it represents the front/cover of a digipack-cd, other front/cover images should not be displayed if its got a digipack-cover). The next set of images should be the inset/inner-sleeve/cards and they should be in numerical order from page1 -page14 etc. Lastly in this group would be the closed single-sided back to the booklet if it is available. Cd-images go here, disk1, disk2, etc. Lastly the Back-Cover of the CD or possibly digipack(if the back image is separated from the front).

I know this is what you are attempting to accomplish I just thought I should offer up suggestions and support to manage this weighting of images. I know you will do it. This would be the first music browser that I have ever encountered that supports all the artwork and information that accompanies a cd,lp,etc. VERY COOL! I say this having used MAC/WIN/& LINUX music players...and I have tried nearly everyone I could find. You are on the right track to something new, different, and very cool!

On Sun, Jul 31, 2016 at 12:30 PM, Josh B-W killhellokitty@gmail.com wrote:

I'll go ahead and give this a try even though the actual music is unavailable; the images are shown properly at this time. I'm not sure about only having it weighing for the first import. Generally we update the database because we have added new music files to our collection. New files means new images. Maybe it would be best to set the 'update sliMPD database' button on the 'importer' page; instead of doing an update to database, have it do a full reinstall of the database so that all new music added will have weighted images as well. I really would like that button to be the magic button to install and create the database soooooooo bad. ;-)

On Sun, Jul 31, 2016 at 5:55 AM, othmar52 notifications@github.com wrote:

please pull the latest commits https://github.com/othmar52/slimpd/commit/0b287bc2aab4ab6d8126d7e5a58efa13893d8d1a and give it a try.

NOTE: to save performance on all frequent database updates this weightening is only applied during the very first import into sliMpd's database. So the best is to drop the database and recreate it as there also had been some structural database changes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-236423545, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslVLJB6lr9ZF-RWJ0EQafe9BK4PHDks5qbH8RgaJpZM4JTnt3 .

othmar52 commented 8 years ago

i have created a sheet with album file list. please fill column D with your preferred sorting on each image line.

As sliMpd is in very early stage we have all freedom for implementing stuff. this means we are not limited to the current picture types. we can add as much picture types as we want - even if they will be only used for sorting.

I also can imagine an additional link just for the booklet in albumview without displaying the booklet thumbnails at all. feel free to share your ideas!

Deciding wich duplicates of pictureType:front should not be displayed is a bit tricky in an automated process, isn't it?

killhellokitty commented 8 years ago

I filled in D with comments. I really like the idea of a link for booklet to be displayed, that would keep it much cleaner looking. I'm not sure if digipack needs to be displayed at all if there are both front and back cover images. Not sure how that should work out.

Getting rid of the duplicates of the Front is understandably difficult.

On Tue, Aug 2, 2016 at 1:16 PM, othmar52 notifications@github.com wrote:

i have created a sheet with album file list https://docs.google.com/spreadsheets/d/14z1AffYoC1IhAs08FIyZjEhDSQcVNVsFO3dvqor2TSc/edit?usp=sharing. please fill column D with your preferred sorting on each image line.

As sliMpd is in very early stage we have all freedom for implementing stuff. this means we are not limited to the current picture types https://github.com/othmar52/slimpd/blob/master/config/importer/image-weights.ini. we can add as much picture types as we want - even if they will be only used for sorting.

I also can imagine an additional link just for the booklet in albumview without displaying the booklet thumbnails at all. feel free to share your ideas!

Choosing wich duplicates of pictureType:front should not be displayed is a bit tricky in an automated process, isn't it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-236993537, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslRPr9iViG0kh4i4i7OlK0ysYYNAHks5qb4mMgaJpZM4JTnt3 .

othmar52 commented 8 years ago

please add numbers in column E with your preferred sorting for all images that should be displayed

killhellokitty commented 8 years ago

Okay, done. Sorry about yesterday, I'm not always good at expressing what I mean to say, and it comes out off-putting. My apologies.

Regards, Josh

On Wed, Aug 3, 2016 at 12:50 AM, othmar52 notifications@github.com wrote:

please add numbers in column E with your preferred sorting for all images that should be displayed

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-237148069, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslRZu1qW4WaL1rQGRfrihV8WVn4JAks5qcCwYgaJpZM4JTnt3 .

othmar52 commented 8 years ago

there had been some progress on this issue. feel free to pull the latest commits and give it a try. as there had been database changes a ./slimpd hard-reset is required

further you have to set this option in your config/config_local.ini config as it is disabled by default

[images]
hide_front_duplicates = 1
killhellokitty commented 8 years ago

I added the following:

[images] hide_front_duplicates = 1

and will perform the ./slimpd hard-reset.

I will get back to you, and let you know how it turns out.

On Fri, Aug 12, 2016 at 7:17 AM, othmar52 notifications@github.com wrote:

there had been some progress on this issue. feel free to pull the latest commits and give it a try. as there had been database changes a ./slimpd hard-reset is required

further you have to set this option in your config/config_local.ini config as it is disabled by default

[images]hide_front_duplicates = 1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-239431314, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslR6LCMxZ2V1dEljJtnc7e4HOPNohks5qfGRfgaJpZM4JTnt3 .

killhellokitty commented 8 years ago

It looks like it worked pretty well. The 'New Order-Power Corruption and Lies' still has one large cover and a small but different cover. Its using 'Front-2.jpg as the large default cover and Front.jpg as a small secondary cover. The Default cover should be 'Front.jpg' the other 'Front-2.jpg is an original release cover, here only for completeness. It shouldn't show 'Front-2.jpg' at all. 'Front.jpg' should have priority over the other and be the one on display. the other is a secondary cover(in this case for historical purposes), but not to be displayed. I think I beat that one into the ground...sorry.

The rest of the images look good.

As for the booklet, AWESOME! Works like a charm. I love it!

On Fri, Aug 12, 2016 at 8:41 AM, Josh B-W killhellokitty@gmail.com wrote:

I added the following:

[images] hide_front_duplicates = 1

and will perform the ./slimpd hard-reset.

I will get back to you, and let you know how it turns out.

On Fri, Aug 12, 2016 at 7:17 AM, othmar52 notifications@github.com wrote:

there had been some progress on this issue. feel free to pull the latest commits and give it a try. as there had been database changes a ./slimpd hard-reset is required

further you have to set this option in your config/config_local.ini config as it is disabled by default

[images]hide_front_duplicates = 1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-239431314, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslR6LCMxZ2V1dEljJtnc7e4HOPNohks5qfGRfgaJpZM4JTnt3 .

killhellokitty commented 8 years ago

Sorry, just checked the 'Siouxsie and the Banshees' album I had sent to you and it still has 2 covers. One large and one small. :-(

On Fri, Aug 12, 2016 at 9:48 AM, Josh B-W killhellokitty@gmail.com wrote:

It looks like it worked pretty well. The 'New Order-Power Corruption and Lies' still has one large cover and a small but different cover. Its using 'Front-2.jpg as the large default cover and Front.jpg as a small secondary cover. The Default cover should be 'Front.jpg' the other 'Front-2.jpg is an original release cover, here only for completeness. It shouldn't show 'Front-2.jpg' at all. 'Front.jpg' should have priority over the other and be the one on display. the other is a secondary cover(in this case for historical purposes), but not to be displayed. I think I beat that one into the ground...sorry.

The rest of the images look good.

As for the booklet, AWESOME! Works like a charm. I love it!

On Fri, Aug 12, 2016 at 8:41 AM, Josh B-W killhellokitty@gmail.com wrote:

I added the following:

[images] hide_front_duplicates = 1

and will perform the ./slimpd hard-reset.

I will get back to you, and let you know how it turns out.

On Fri, Aug 12, 2016 at 7:17 AM, othmar52 notifications@github.com wrote:

there had been some progress on this issue. feel free to pull the latest commits and give it a try. as there had been database changes a ./slimpd hard-reset is required

further you have to set this option in your config/config_local.ini config as it is disabled by default

[images]hide_front_duplicates = 1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-239431314, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslR6LCMxZ2V1dEljJtnc7e4HOPNohks5qfGRfgaJpZM4JTnt3 .

othmar52 commented 8 years ago

Yes, i know it isn't fixed yet. Therefore i wrote

...there had been some progress on this issue...

I will update the issue as soon as i have it fixed.

killhellokitty commented 8 years ago

Why isn't it fixed yet. I want it fixed NOW! I want it, and I deserve to have it, RIGHT NOW! HeHeHe!!!

Just joking. I know you are working hard on it, and I am aware that its a real 'Son-of-a-Bitch', pardon my "french" ;-)

SliMpd is coming along great! I love the booklet app!!!! Fucking-Great!!!!!!! The only problem I noticed with it, which may be intentional. Is that after the last page of the booklet, it automatically begins again at the start of the booklet rather than coming to a halt. Also the button is kinda strangely placed. I remember you said you have a mate thats going to help you to rework the interface GUI/CSS, so its unimportant right now.

On Sat, Aug 13, 2016 at 4:27 AM, othmar52 notifications@github.com wrote:

Yes, i know it isn't fixed yet. Therefore i wrote

...there had been some progress on this issue...

I will update the issue as soon as i have it fixed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-239611912, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslUjXXLUJDSCvmi7dExrmS2nxeJrQks5qfY3lgaJpZM4JTnt3 .

othmar52 commented 8 years ago

please give it another try. in the meantime there had been several database changes so please hard-reset your installation

killhellokitty commented 8 years ago

Hey, Will do. I'll give it a go tomorrow. Thanks

On Mon, Aug 29, 2016 at 5:01 AM, othmar52 notifications@github.com wrote:

please give it another try. in the meantime there had been several database changes so please hard-reset your installation

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-243084343, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKsldlfGrHXzXXDZaRqZzZ7CY5EiIScks5qkq4QgaJpZM4JTnt3 .

killhellokitty commented 8 years ago

WOW!!!,

You have really made some headway with SliMpd. I am impressed! Well done my friend, well done.

It looks sooooooooooo much cleaner and user friendly. I see you have gotten several new items working. I haven't had time to really play with it yet, but I'm gonna today.

I wanted to ask, on the Playlists page I recieve this error: 'ACCESS RESTRICTION: Real Path (/) is not inside your configured music-directory (/media/Music/). Please configure [mpd]alternative_musicdir' . What exactly does this mean? What do I need to do to make this go away. Its not entirely clear.

I'm still working on the Gtk-Theme for the Viperr-OS, I am very pleased with myself, so I must share with you; I have created the first Gtk3 theme that blends near(very, very, very) close to the Openbox3 theme. The OS is Openbox based, and Gtk3 apps look like SHIT in Openbox, they have no matching window-theme and usually have big squares around them, especially the apps that use Header-Bars. But I tinkered till I found a way to make everything match. You can use any Gtk3 app in Openbox and it looks native. Alright enough of my gloating. I had to share. Anyway, I have finished both Gtk2 and Gtk3 as well as the Openbox-theme, now all I have is the FIrefox-wrapper and maybe (I haven't decided, cause its very difficult to do) a Thunderbird-wrapper to match the themes. Then I will be done. And would be pleased if you are still interested in my continuing contributions to SliMpd.

Again, congratulations...you have made some fantastic progress!

Cheers, Josh

On Mon, Aug 29, 2016 at 6:49 PM, Josh B-W killhellokitty@gmail.com wrote:

Hey, Will do. I'll give it a go tomorrow. Thanks

On Mon, Aug 29, 2016 at 5:01 AM, othmar52 notifications@github.com wrote:

please give it another try. in the meantime there had been several database changes so please hard-reset your installation

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/21#issuecomment-243084343, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKsldlfGrHXzXXDZaRqZzZ7CY5EiIScks5qkq4QgaJpZM4JTnt3 .