search

othmar52 / slimpd

PHP/JS based MPD-web-client for large music collections
GNU Affero General Public License v3.0
41 stars 11 forks source link

filetype quicktime - Losless compression, wrong name #25

Closed killhellokitty closed 8 years ago

killhellokitty commented 8 years ago

Under file type it should list this as M4A or m4a, it is actually MPEG-4 Audio. It is: advanced audio coding (AAC) losless format. Quicktime is an incorrect description of the codec.

othmar52 commented 8 years ago

scanning metadata of music files is done by an external library (JamesHeinrich/getID3)

i have added another debug possibility trackwidget -> edit -> dump metadata new link for dumping metadata

I think the issue should be reported to the getId3 repo!? maybe the problem is related to this issue.

killhellokitty commented 8 years ago

For the time being I would do something like was suggested:

Meanwhile you can do something like $info['mime_type'] = ((($info['mime_type'] == 'audio/quicktime') && preg_match('#.(m4a)$#i', $info['filename']) ? 'audio/m4a' : $info['mime_type']); where $info is the array returned from getid3->analyze and that should modify the MIME type based on filename.

As it doesn't appear as though the author has any intention of making any changes to what is seen as a Quicktime mime type. I suggest you attempt to add the suggested workaround. Because Quicktime-codec and M4A are not the same thing. Anyone who has ever owned a Mac and worked with audio knows the difference.

Regards Josh

On Fri, Jul 29, 2016 at 4:15 AM, othmar52 notifications@github.com wrote:

scanning metadata of music files is down by an external library ( JamesHeinrich/getID3 https://github.com/JamesHeinrich/getID3)

i have added https://github.com/othmar52/slimpd/commit/5cbca436e3379f090adb0af50689d2d9aed9b4c5 another debug possibility trackwidget -> edit -> dump metadata [image: new link for dumping metadata] http://gas-werk.org/slimpd/2016-07/dump-meta-link.png

I think the issue should be reported to the getId3 repo!? maybe the problem is related to this issue https://github.com/JamesHeinrich/getID3/issues/48.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/othmar52/slimpd/issues/25#issuecomment-236133307, or mute the thread https://github.com/notifications/unsubscribe-auth/AJKslWLqYBW80_z2bv8tRtuvwfkKegz3ks5qacSxgaJpZM4JWhAv .

killhellokitty commented 8 years ago

Fixed