search

othmar52 / slimpd

PHP/JS based MPD-web-client for large music collections
GNU Affero General Public License v3.0
41 stars 11 forks source link

Finish up the systemcheck page #46

Closed smuth4 closed 7 years ago

smuth4 commented 7 years ago

Issue #4 is actually a matter of locale (see http://php.net/manual/en/function.escapeshellarg.php#99213), and even though it's been worked around, I added a check to make sure escapeshellarg handles UTF-8 nicely, just to avoid any other edge cases.

smuth4 commented 7 years ago

Huh, the locale check is definitely functioning correctly but it looks like for about 50% of the systemcheck runs, the locale is somehow getting set to C instead of en_EN.UTF-8. Gotta love PHP.

othmar52 commented 7 years ago

Thank you! Unfortunately I can't remember on which testmachine i had those errors mentioned in #4. But thanks to you your finding i should be able to reproduce it by changing locale settings. i am going to remove my workaround and close #4