othree / es.next.syntax.vim

ES.Next syntax for Vim
MIT License
125 stars 7 forks source link

Break in TS syntax #10

Closed mhartington closed 7 years ago

mhartington commented 7 years ago

Hi there! Thanks for the plugins you make.

It seems that this last commit, https://github.com/othree/es.next.syntax.vim/commit/29bc7a11763c59ee899916cdfdd556824ee216a4, breaks typescript syntax highlighting for decorators while using yats.vim

screen shot 2017-02-15 at 4 30 26 pm

othree commented 7 years ago

Could you try git checkout f09d06d237179abb5171eedbd3363b5747e93f0b

mhartington commented 7 years ago

It "fixes" it by not causing an error, but still seems to be interfering with decorators

With es-next and yats.vim

screen shot 2017-02-16 at 8 09 41 am

without es-next

screen shot 2017-02-16 at 8 10 04 am
othree commented 7 years ago

I need some code snippets to debug.

mhartington commented 7 years ago

Sorry for the delay

@Component({
  selector: 'page-home',
  templateUrl: 'home.html'
})
othree commented 7 years ago

This is what I see with latest yats and es.next.syntax.vim.

2017-02-18 10 44 39

Do you upgrade yats too ?

mhartington commented 7 years ago

Hmm, alright it must be something else in my config, as loading only yajs.vim, yats.vim, and es.next seems to not create a conflict in this minimal vimrc

```vim set runtimepath+=~/.config/nvim/repos/github.com/Shougo/dein.vim/ call dein#begin(expand('~/.config/nvim')) call dein#add('Shougo/dein.vim') call dein#add('haya14busa/dein-command.vim') call dein#add('HerringtonDarkholme/yats.vim') call dein#add('othree/yajs.vim') call dein#add('othree/es.next.syntax.vim') if dein#check_install() call dein#install() endif call dein#end() filetype plugin indent on set clipboard+=unnamedplus let mapleader = ',' nnoremap e :call SynStack() function! SynStack() if !exists("*synstack") return endif echo map(synstack(line('.'), col('.')), 'synIDattr(v:val, "name")') endfunc ```

screen shot 2017-02-21 at 9 37 03 am

Sorry for the noise! Thanks for you help and plugins 😄

mhartington commented 7 years ago

And just like that, I found it. Ended up being a conflict with vim-node