othyn / macos-auto-clicker

A simple auto clicker for macOS Big Sur, Monterey, Ventura and Sonoma.
MIT License
208 stars 24 forks source link

feat: Notification options for when auto clicker starts and/or finishes #66

Closed AnonymousAlt0 closed 1 year ago

AnonymousAlt0 commented 1 year ago

Description

An extra tab has been added to Settings for notifications. Two checkboxes to toggle whether you receive a macOS notification when the auto clicker starts and/or finishes running. macOS will request notification permissions when a checkbox has been toggled for the first time. A notification service has been added for future expansion of app notifications in mind (it's just a single static function atm).

Related Issue

None

Motivation and Context

Addresses the Issue 'Notifications #64' with tag 'Enhancement'.

How Has This Been Tested?

Tested thoroughly on two different machines (intel and Apple Silicon).

Types of changes

Checklist

othyn commented 1 year ago

Closes #64 when merged

AnonymousAlt0 commented 1 year ago

I'll make sure I use SwiftLint next time. Is there anything else I missed?

othyn commented 1 year ago

Just taking a look now, Xcode is doing its usual thing and updating lmao

othyn commented 1 year ago

Other than a few formatting things that SwiftLint picked up, there was a bug with notification intervals <= 0 silently throwing an exception and not registering the notification. I've put in a bug fix for this, but that was it that I could see!

othyn commented 1 year ago

Thanks for the PR, greatly appreciated

AnonymousAlt0 commented 1 year ago

there was a bug with notification intervals <= 0

Ah yeah, sorry I saw that but forgot the fix it.

Thanks for the PR, greatly appreciated

No worries. It was a nice project to work in, well-organised. I'll get started on the feature I requested soon.

othyn commented 1 year ago

No worries. It was a nice project to work in, well-organised. I'll get started on the feature I requested soon.

Thanks! Its handy to have some feedback on that as its difficult to know when working alone haha