search

otiai10 / copy

Go copy directory recursively
https://pkg.go.dev/github.com/otiai10/copy
MIT License
723 stars 115 forks source link

Fix small bug in lcopy and test setup #28

Closed MartinPetkov closed 4 years ago

MartinPetkov commented 4 years ago
  1. Check errors during test setup.
  2. Create directories on the path to dest in lcopy().
codecov-commenter commented 4 years ago

Codecov Report

Merging #28 into master will increase coverage by 0.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   87.36%   87.62%   +0.26%     
==========================================
  Files           2        2              
  Lines          95       97       +2     
==========================================
+ Hits           83       85       +2     
  Misses          6        6              
  Partials        6        6
Impacted Files Coverage Δ
copy.go 86.51% <100.00%> (+0.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d357d62...2d9637b. Read the comment docs.

MartinPetkov commented 4 years ago

@otiai10 Please review.

otiai10 commented 4 years ago

Overall, I really appreciate your PR and love it. Please check some comment I left and correct me if I'm wrong. Thank you ;)