search

otiai10 / copy

Go copy directory recursively
https://pkg.go.dev/github.com/otiai10/copy
MIT License
723 stars 115 forks source link

copy.Copy hangs with named pipes #47

Closed mudler closed 3 years ago

mudler commented 3 years ago

It seems that copy.Copy is not supporting named pipes, at the moment it tries to copy it, resulting in the process to hang.

Would you be interested in accepting a PR to reproduce the named pipe in the given destination ?

otiai10 commented 3 years ago

Thank you for your feedback! It makes sense for me and I've got your point. It seems good time to start discussion on the design of v2, and we can put this on that. What do you think?

Though I can see your commit referencing to this issue, your PR would be super appreciated!! 🥰

mudler commented 3 years ago

Thank you for your feedback! It makes sense for me and I've got your point. It seems good time to start discussion on the design of v2, and we can put this on that. What do you think?

Makes sense :slightly_smiling_face:

Though I can see your commit referencing to this issue, your PR would be super appreciated!! smiling_face_with_three_hearts

Alright then :smile_cat: probably won't be able to work on it today, but I'll open a PR asap among the lines of my commit, but I would avoid to apply permission changes, because likely would need #48 on top

mudler commented 3 years ago

@otiai10 opened up https://github.com/otiai10/copy/pull/50 to address this issue! :slightly_smiling_face: :+1:

otiai10 commented 3 years ago

Published under v1.5.0. Thank you for your insight and contribution ❤️