Closed flimzy closed 2 years ago
Merging #75 (94e412f) into main (9aae5f7) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 77.40% 77.40%
=======================================
Files 13 13
Lines 177 177
=======================================
Hits 137 137
Misses 20 20
Partials 20 20
Impacted Files | Coverage Δ | |
---|---|---|
copy_namedpipes.go | 33.33% <ø> (ø) |
|
copy_namedpipes_x.go | 0.00% <ø> (ø) |
|
stat_times.go | 100.00% <ø> (ø) |
|
test_setup_x.go | 100.00% <ø> (ø) |
|
test_setup.go | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9aae5f7...94e412f. Read the comment docs.
I don't know that there's anything I can do about the failing tests, as they appear to be transient failures. Is there anything I can do to help this PR advance?
@flimzy Thank you. Though I'm still investigating the failing tests, I believe this PR can be merged. Just let me take 1 more day to suppress failing cases.
Thank you again for your proposal!
Thanks!
It just occurred to me that it might be valuable to have tests run against wasm and GopherJS, as well. If you'd like, I'm happy to submit another PR to add those targets to the CI configuration.
that would be perfect! no pressure
At present, this package does not work with WASM or GopherJS compile targets. See for example, the output from
go test
for WASM:and GopherJS:
This PR solves this problem, by using the same fallback used for Windows, which doesn't support Mkfifo, and by using the JS-specific struct field names for Atime/Ctime fields in the
syscall
package.