search

otiai10 / gosseract

Go package for OCR (Optical Character Recognition), by using Tesseract C++ library
https://pkg.go.dev/github.com/otiai10/gosseract
MIT License
2.67k stars 287 forks source link

feat: add DetectOrientationScript method #299

Closed joelrose closed 3 months ago

joelrose commented 8 months ago

This exposes the DetectOrientationScript method. I've used this for quite some time privately and would like to bring this upstream.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 69.25%. Comparing base (d85513d) to head (29d25d8). Report is 7 commits behind head on main.

Files Patch % Lines
client.go 52.63% 12 Missing and 6 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #299 +/- ## ========================================== - Coverage 71.47% 69.25% -2.23% ========================================== Files 1 1 Lines 284 322 +38 ========================================== + Hits 203 223 +20 - Misses 67 79 +12 - Partials 14 20 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rubiojr commented 7 months ago

This has been helpful to me :pray:. Worth mentioning perhaps that using this requires an optional (in Fedora Linux at least) package that needs to be installed (tesseract-osd), or you'll get a failed to initialize TessBaseAPI with code -1 runtime error, which was confusing.

otiai10 commented 6 months ago

Alpine test is failing. (please ignore vagrant)

joelrose commented 6 months ago

Hi @otiai10, thanks for your review! I've fixed the issue, so the alpine test should pass now. Could you review again or merge if all's good? Thanks!

otiai10 commented 3 months ago

I fixed clearlinux case.

otiai10 commented 3 months ago

Sorry I misunderstood that I fixed your issue by #309

I revert this PR by #310, so please reopen this PR with all test case green.