search

otiai10 / opengraph

Open Graph Parser for Go
https://pkg.go.dev/github.com/otiai10/opengraph
MIT License
65 stars 13 forks source link

Use <title> as a last resort, not an override #6

Closed mbleigh closed 4 years ago

mbleigh commented 4 years ago

I think this is the intention of the code, and certainly works better as the current behavior will override an actual og:title tag.

codecov-io commented 4 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   82.89%   82.89%           
=======================================
  Files           4        4           
  Lines         152      152           
=======================================
  Hits          126      126           
  Misses         17       17           
  Partials        9        9
Impacted Files Coverage Δ
tag_title.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b197f62...e0ab418. Read the comment docs.

otiai10 commented 4 years ago

Thank you. I can't agree more with your point :+1: