search

otissv / graphql-guru-ide

Frontend IDE client for GraphQL Guru
MIT License
1 stars 0 forks source link

maybe I can use your help #3

Open orefalo opened 7 years ago

orefalo commented 7 years ago

Hi Otis,

I started adding a graphql-voyager tab in the app, but... I am far from a React expert at this point. ;-/

Maybe I can use some of you help, I did more of the cosmetic changes under this commit https://github.com/orefalo/graphql-guru-ide/commit/17f768691b93b814dcf5ee54a6d924b61a952b79

I can't figure how to invoke the react component - https://github.com/orefalo/graphql-guru-ide/blob/17f768691b93b814dcf5ee54a6d924b61a952b79/src/modules/schema/components/Graph-schema.js

Thank you Olivier

otissv commented 7 years ago

Hi,

The import should be import { Voyager } not import Voyager. Also the <Voyayer /> component requires an introspection prop which is a function that accepts a query string. The graphql redux has introspection but a function. I would put the introspection function as a redux action and keep its state in the store. Other than that everything is wired up correctly.

On another note, I wouldn't put this under scheme but give it its own module as it's a separate feature.

orefalo commented 7 years ago

thank you - will adjust