Request: Feature: Item Abilities in Lua functions

[Codinablack]

I was looking in the source, and it doesn't seem like there needs to be anything altered to implement this, the only thing I think would be to add the functions in luascript

Item:hasAbility("ability", "sub-type") -- returns true or false Item:getAbility("ability", "sub-type") -- returns value Item:setAbility("ability", "sub-type", value) -- sets value for ability and specific sub-type.

ItemType:getAbility("ability", "sub-type")

Example use:

local fireAbsorption if Item:hasAbility("absorb", "fire") then fireAbsorption = Item:getAbility("absorb", "fire") else fireAbsorption = ItemType(Item:getId()):getAbility("absorb", "fire") end

Could be used for skills, absorbpercent, fieldabsorbpercent, stats, statspercent, speed, health gain, mana gain, regeneration, anything you can already put in items.xml

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[Zbizu]

has/getAbility should be easy to add. With "set" this is needed:

• new table in database(unless you store abilities in attributes field)
• function to load/save abilities(unless this ^)
• redirecting reading abilities to item instead of itemid
• huge list like in attributes or something to allow larger values in enum

[andersonfaaria]

About this, I have a very strong opinion that we should completely rewrite ItemType structure. Most of the tfs checks things in itemtype instead of item and it makes several attributes only be read if they are declared in items.xml.

I do understand the facilities that the class-object format gives for instanciating an item with their attributes from XML, but this becomes a huge problem when you consider making custom items.

IMO we could use portions of the edits done by @infernumx here https://github.com/infernumx/forgottenserver/compare/master...infernumx:abilities-remove