[Question] onManaChange(creature, attacker, manaChange, origin)

[conde2]

How do I know if the player is gaining mana or losing mana ?

Because manaChange is always positive.

[conde2]

https://github.com/otland/forgottenserver/blob/70590833b25f6b6a137c5e45ce29b254edddadf8/src/game.cpp#L4105

Shouldn't it be manaLoss? https://github.com/otland/forgottenserver/blob/70590833b25f6b6a137c5e45ce29b254edddadf8/src/game.cpp#L4120

[conde2]

@WibbenZ @Mkalo Could you guys check this issue please ?

[ranisalt]

Shouldn't it be manaLoss?

No. manaLoss is the absolute value (on the else branch, manaChange is non-positive so manaLoss is non-negative). The value sent to onManaChange can be positive or negative, from the code you shown.

[Mkalo]

I do have this: https://gist.github.com/Mkalo/2b1c4bcd772e161a1200cfeb820d3aba

But I never created a PR cause I didn't have time before, I could do it if this is okay.

@ranisalt

[WibbenZ]

Imo this issue is kinda related to #1211, seeing as the functions need an overhaul.

[Mkalo]

I don't know if onManaChange should be executed for spell casting anyway, (It doesnt use any combat function just Creature::changeMana).

We could change that and make it fire a combat (Game::combatChangeMana) and use ORIGIN_SPELL.

[WibbenZ]

As mark wrote this function should be used as much as we can. Look at #1226