TFS IP address format

[gunzino]

• [x] This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
• [x] This issue is reproducible without changes to the code in this repository

TFS saving IP addresses in opposite way. For example IP 0.0.0.1 should be in long format 1 but in TFS it is 16777216.

Expected behaviour

I am not 100% about that but PHP functions long2ip and ip2long should be working with TFS databases. Instead, you need to create special functions that swap the quads of an ip address.

Actual behaviour

I need to use edited functions to get the IP from long. There is an example code: `
public static function TfsLong2Ip($tfs_ip) { $ipp = long2ip($tfs_ip); $quads = explode(".", $ipp); $ip = $quads[3].".".$quads[2].".".$quads[1].".".$quads[0]; return $ip; }

public static function Ip2TfsLong($ip) {
    $quads = explode(".", $ip);
    $tfs_ip = $quads[3].".".$quads[2].".".$quads[1].".".$quads[0];
    return ip2long($tfs_ip);
}`

Environment

TFS & PHP

[Shawak]

Are you running on a 32 bit machine? If yes read the notes: http://php.net/manual/de/function.long2ip.php

[Mkalo]

There is nothing wrong with TFS, it is converting in big endian as PHP uses little endian. You should do a function to get the string from a big endian encoded long as Game.convertIpToString: https://github.com/otland/forgottenserver/blob/33d074fe1cb28d7f094e0e6896ada65d9cd472a2/data/lib/core/game.lua#L11

And one to convert big endian long to little endian long.

[gunzino]

Yeah thats what I do. If you copy TFS long to any converter on the web you will get bad result.

Is there some special reason to use big endian ?

[marksamman]

It was inherited from https://github.com/opentibia/server. It can't be fixed without breaking everything that depends on the old format.