search

otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.59k stars 1.06k forks source link

[bug or suggestion?] Mana and manapercent in spells.xml #2733

Open Olrios opened 4 years ago

Olrios commented 4 years ago

Steps to reproduce

  1. create spell with both mana="10" and manapercent="50" in spells.xml
  2. cast it

Actual behaviour

it will consume only 10 mana but not extra 50% of max mana

Expected behaviour

Code should not ignore manapercent if there is mana too. And calculate both mana and manapercent into the final cost. Spells would be able to cost 10 mana + 50% of max mp for example

Olrios commented 4 years ago

Is it okey? https://github.com/otland/forgottenserver/pull/2734/commits/68c87ec3d5ef00159ebceef561d3bdc5d7ae9bf1

zeeb1337 commented 4 years ago

Legit question, I think it should be added.

Znote commented 4 years ago

This is already added? Someone should confirm and possibly close this issue.

Olrios commented 4 years ago

Here is pull request for it: https://github.com/otland/forgottenserver/pull/2734