Two missing things on spellbook

otland / forgottenserver

A free and open-source MMORPG server emulator written in C++

https://otland.net

GNU General Public License v2.0

1.59k stars 1.06k forks source link

Two missing things on spellbook #3651

Open EPuncker opened 3 years ago

EPuncker commented 3 years ago

theres 2 things left to-do on spellbook:

utevo res para - Summon Creature : var "var" should be displayed instead of mana, if the manacost is 0 if spell.mana == 0 then spell.mana = "var" end - something like this mby

aleta sio - Invite Guests : - "-" should be displayed instead of mana, if its a house spell

Originally posted by @emil92b in https://github.com/otland/forgottenserver/issues/3649#issuecomment-919587641

Zbizu commented 3 years ago

I suggest adding an exception to the way these spells are displayed. There are at least 3 ways to solve that:

check for 0 in flat/percent cost in xml and print "-", + setting customCost boolean flag to display var in spellbooks
make exceptions in spellbook script
creating displayCostAs flag in xml and introducing spell:getCostString() method

Personally I would just call costString[spellId] or (x .. " mana") in spellbook script (solution 2)