otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.59k stars 1.06k forks source link

floorchange unpass objects #3680

Closed ghost closed 3 months ago

ghost commented 3 years ago

Before creating an issue, please ensure:

Steps to reproduce (include any configuration/script required to reproduce)

  1. place 3 parcels and try to go up a floor onto an "unpass" object like a statue or trough
  2. try to stack 2 unpassable objects aswell by pushing them into floorchange, you will get same result "not enough room"

Expected behaviour

tested on rl-tibia and it should be possible bug

stack

Actual behaviour

"there is not enough room."

Environment

Reproduction environment

EPuncker commented 3 years ago

maybe it was possible on 10.98 version, we will have to wait for version 12.x to try it again since we can't test on official 10.98 anymore, unless we find a video

Zbizu commented 3 years ago

https://github.com/otland/forgottenserver/blob/c9a65a8051d0e6aa59889b6c47aba77e74cd6f0b/src/game.cpp#L807

https://github.com/otland/forgottenserver/blob/c9a65a8051d0e6aa59889b6c47aba77e74cd6f0b/src/game.cpp#L823

my guess is that we have to use something other than TILESTATE_BLOCKSOLID

we could try TILESTATE_IMMOVABLEBLOCKSOLID, but I'm not sure if it's working properly

ghost commented 3 years ago

added another example with stacking items by floorchange

ghost commented 3 years ago

maybe it was possible on 10.98 version, we will have to wait for version 12.x to try it again since we can't test on official 10.98 anymore, unless we find a video

version 7.7 works the same as tibia 12.71, so doubt any difference on 10.98 123123

Zbizu commented 3 years ago

Yeah it was like that since feature introduction probably. Please test if my pull request fixes the issue.

ghost commented 3 years ago

Yeah it was like that since feature introduction probably. Please test if my pull request fixes the issue.

yes it is working, only thing left is stacking those items by adding into floorchange like on the second picture

Zbizu commented 3 years ago

hey, do you play on pvp world? Please test if you can levitate/parcelwalk towards magic walled tiles

ghost commented 3 years ago

hey, do you play on pvp world? Please test if you can levitate/parcelwalk towards magic walled tiles

you cannot, also teleport effect on levitate and magic rope should be sent on previous position

Zbizu commented 3 years ago

I'll look into magic rope later. I've added a commit that changes how magic effect is launched for levitate. Check if the spell is 100% accurate now.

ghost commented 3 years ago

I'll look into magic rope later. I've added a commit that changes how magic effect is launched for levitate. Check if the spell is 100% accurate now.

ye levitate seems to be alright now, i only noticed that it seems to be case sensitive for the parameter

Zbizu commented 3 years ago

added a commit to ignore case sensitivity and spaces in param

ghost commented 2 years ago

@DSpeichert you could atleast read before randomly closing, that PR didnt fix all

Zbizu commented 2 years ago

what else is here to do?

ghost commented 2 years ago

what else is here to do?

ghost commented 2 years ago

33