otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.6k stars 1.06k forks source link

Strange bug with doors #374

Closed Kamenuvol closed 10 years ago

Kamenuvol commented 10 years ago

Well, I was just testing out my compilation of TFS 1.0 rev 873 without any changes and I was playing of create items. I had an idea and created a door, open door id 1211, and it wasn't closing! So I've tested creating a lot of other doors around and the most of them closes, but some of them only close after create other doors around! And others I cant close until now. I dont have any idea what is happening. doors Maybe I will try other kinds of doors and items which transform on use and update this issue.

I hope you can reproduce it. Kamenuvol

Zbizu commented 10 years ago

it happens when there is detail such as grass or small rock below door detail is moved to the top, probably stackpos issue

Kamenuvol commented 10 years ago

Yeah, I thought it. But it does not explain how some of them closed after I'd created another door beside it. Or I'd just missclicked the door coincidently before made others, and then clicked right.

Zbizu commented 10 years ago

just don't stack doors with other doors/archways about bugging with details: I have no idea how to fix that.

jpmagg commented 10 years ago

I got the same bug :/

andypsylon commented 10 years ago

Here an interesting change: https://github.com/edubart/otclient/commit/82a5989f5cfa77cbae890c13697becdc0338c967 If you use otclient

Zbizu commented 10 years ago

@andypsylon It's server/otb sided - closed door go automatically to the top of stack even when doTeleportThing is used to assign stackpos, open door go to the bottom. Changes in sources to treat rocks, grass tufts and snow details as borders or item with door attribute sent to client as top item should solve this problem.

marksamman commented 10 years ago

This is working as intended/wontfix.