otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.59k stars 1.06k forks source link

Problems with decoration kit #3821

Open omarcopires opened 2 years ago

omarcopires commented 2 years ago

Before creating an issue, please ensure:

Steps to reproduce (include any configuration/script required to reproduce)

https://youtu.be/uwLj8owsgBQ

Expected behaviour

I'm not absolutely sure, however, I believe it should be impossible to unwrap packages inside the store inbox and it is also not possible to move the package into the house, which should be allowed.

Zbizu commented 2 years ago

while I haven't owned any house after they started adding store items, I believe that the kits with store flag shouldn't be allowed to be dropped on the floor, even in houses.

Regarding wrap/unwrap logic: only house owner should be allowed to do that. Also: store items shouldn't be possible to move out of house and they shouldn't be possible to trade. The store items are just meant to be untransferable.

This is a whole system to introduce.

omarcopires commented 2 years ago

@Zbizu decoration kit should be dragged into the house only, so it can be unwrapped.

This item cannot be traded through the Marketplace. When you buy any decoration item from the Store, it will come inside a Decoration Kit. You can unwrap the items by right-clicking and "Unwrap" when inside your house. You can also wrap the object again by clicking "Wrap". Here are some rules of the item:

- The item will only be groupable if it belongs to the same piece of furniture;
- The kit can only be stored in Store Inbox, Inbox or Depot Chest;
- To unwrap the furniture, you must own the house;
- You cannot trade the kit;
- If you lose your home, the mobile will be sent to your inbox.
nekiro commented 2 years ago

while I haven't owned any house after they started adding store items, I believe that the kits with store flag shouldn't be allowed to be dropped on the floor, even in houses.

Regarding wrap/unwrap logic: only house owner should be allowed to do that. Also: store items shouldn't be possible to move out of house and they shouldn't be possible to trade. The store items are just meant to be untransferable.

This is a whole system to introduce.

https://github.com/otland/forgottenserver/pull/3186

EPuncker commented 2 years ago

un/wrapping can be only done if item is on ground, not inside any container and only by house owner