otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.6k stars 1.06k forks source link

Incorrectly displaying special skills #4612

Closed ArturKnopik closed 10 months ago

ArturKnopik commented 10 months ago

Before creating an issue, please ensure:

Steps to reproduce (include any configuration/script required to reproduce)

  1. add to any item

        <attribute key="manaleechamount" value="10"/>
        <attribute key="manaleechchance" value="10"/>
        <attribute key="lifeleechamount" value="20"/>
        <attribute key="lifeleechchance" value="20"/>
        <attribute key="criticalhitchance" value="50" />
        <attribute key="criticalhitamount" value="30" />

    example:

    <item id="2444" article="a" name="hammer of wrath">
        <attribute key="description" value="A giant is said to have forged this hammer to take revenge for the death of his brother." />
        <attribute key="weight" value="7000" />
        <attribute key="defense" value="12" />
        <attribute key="attack" value="48" />
        <attribute key="manaleechamount" value="10"/>
        <attribute key="manaleechchance" value="10"/>
        <attribute key="lifeleechamount" value="20"/>
        <attribute key="lifeleechchance" value="20"/>
        <attribute key="criticalhitchance" value="50" />
        <attribute key="criticalhitamount" value="30" />
        <attribute key="weaponType" value="club" />
        <attribute key="slotType" value="two-handed" />
    </item>
  2. check if item is registred in movements.xml

  3. wear item with attributes added in step 1

  4. check skill window/character combat stats in cyclopedia

Expected behaviour

Correct values displayed

Actual behaviour

Incorrect values displayed image

Environment

not needed

Reproduction environment

not needed