classicAttackSpeed algorithm is bugged and may generate infinite number of scheduler (dispatcher) events.
TFS calls Player::doAttacking every second for every player.
It creates new event g_scheduler.addEvent(task);, which calls Player::doAttacking again with getAttackSpeed() delay. So there is repeating event every 0.2 sec (with attack speed 200) and TFS still calls Player::doAttacking every second creating new event.
That way server can create infinite number of events for 1 player. 1 new event every second.
Often it all stops on if ((OTSYS_TIME() - lastAttack) >= getAttackSpeed()) { - player cannot attack as fast as these events execute, so if there is more than 1 dispatcher event for given player, it won't re-create it after execution (addEvent is inside that IF).
But if player uses melee weapon and his target is not within 1 sqm, his attack will never execute and lastAttack will never update, so it will be able to re-create events, even if there is more than 1 running in same time.
Fixed code limits number of scheduled doAttacking events to 1 per player.
classicAttackSpeedalgorithm is bugged and may generate infinite number of scheduler (dispatcher) events.g_scheduler.addEvent(task);, which callsPlayer::doAttackingagain withgetAttackSpeed()delay. So there is repeating event every 0.2 sec (with attack speed 200) and TFS still callsPlayer::doAttackingevery second creating new event. That way server can create infinite number of events for 1 player. 1 new event every second.Often it all stops on
if ((OTSYS_TIME() - lastAttack) >= getAttackSpeed()) {- player cannot attack as fast as these events execute, so if there is more than 1 dispatcher event for given player, it won't re-create it after execution (addEventis inside that IF). But if player uses melee weapon and his target is not within 1 sqm, his attack will never execute andlastAttackwill never update, so it will be able to re-create events, even if there is more than 1 running in same time.Fixed code limits number of scheduled
doAttackingevents to 1 per player.