search

otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.56k stars 1.04k forks source link

Bug transfering gold to player who doesn't exist in bank NPC #4680

Closed Coldensjo closed 2 months ago

Coldensjo commented 2 months ago

Steps to reproduce (include any configuration/script required to reproduce)

  1. Talk to the bank NPC
  2. Say "hi" "transfer 500 playerwhodoesntexist"
  3. Error in console

Expected behaviour

NPC should say "This player does not exist."

Actual behaviour

Nothing happens

Environment

Basic tfs

Reproduction environment

Basic tfs

EvilHero90 commented 2 months ago

Can't reproduce this client_nPcOlf6jTe

Coldensjo commented 2 months ago

Try saying "transfer 500 randomname" and not "transfer" "500" "randomname"

EvilHero90 commented 2 months ago

Yea this gives an error, I'll include this in #4671 Edit: looking at the source code you are supposed to say it like: transfer 1000 nameofplayer but yea it should not throw an error nonetheless