otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.55k stars 1.04k forks source link

Added missing default dependencies for using vcpkg manifest #4735

Closed Codinablack closed 1 month ago

Codinablack commented 1 month ago

Pull Request Prelude

Changes Proposed

Issues addressed: When using manifest mode with vcpkg, you are unable to build as the features called "http" and "unit-tests" are not enabled by default, and therefore their dependencies are not downloaded, yet files that use them are included in the build.

To fix that, we just enable these features by default.

ranisalt commented 1 month ago

There's something wrong with your setup, since these features will be enabled when you invoke CMake with the vcpkg preset, and you never need to enable them in a separate step

Codinablack commented 1 month ago

Made the requested adjustment