[Revscriptsys]: Register Action/MoveEvent to AID/UID leads to crash of application

[xmish]

By submitting this bug issue, you agree to the following.

• [X] This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
• [X] This issue is reproducible without changes to the C++ code in this repository
• [X] This bug has not been resolved in master branch
• [X] There is no existing issue for this bug already

Does this bug crash tfs?

yes

Server Version

1.7 (Master)

Operation System

Windows

OS Description

10.0.19045.4412

Bug description

when try to register any Action/MoveEvent to action/unique ID, tfs crashes

Possible Pull Requests which are to blame

• [x] #4742

Steps to reproduce

1. create new script
2. register it for Action ID
3. start server
4. crashes at https://github.com/otland/forgottenserver/blob/7011488166d1b6a398a51fc56fe854702a69a160/src/actions.h#L74

Code to reproduce the issue:

local saw = Action()

function saw.onUse(player, item, fromPosition, target, toPosition, isHotkey)
    return true
end

saw:aid(1234)
saw:register()

Actual Behavior

Server crashes: Call stack:

Expected Behavior

Action/MoveEvent can be registed to either action, unique & item ID ranges

Backtrace

No response

[EvilHero90]

can you test #4750 and confirm that it works

[xmish]

@EvilHero90 #4750 Fixes that issue