[Bug]: Going 'sleep' MAY crash server

[gesior]

By submitting this bug issue, you agree to the following.

• [X] This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
• [X] This issue is reproducible without changes to the C++ code in this repository
• [X] This bug has not been resolved in master branch
• [X] There is no existing issue for this bug already

Does this bug crash tfs?

yes (not always)

Server Version

1.7 (Master)

Operation System

all (listed below)

OS Description

No response

Bug description

Going 'sleep' MAY crash server

Possible Pull Requests which are to blame

No response

Steps to reproduce

1. Click on bed (can't check it on 12+, but it may execute C++ action pointed in Actual Behavior)
2. Wait until someone 'wrap' bed item.
3. Try to start sleep.

Actual Behavior

I get report from modified TFS. I cannot run 12+ client on Linux. Can someone confirm it?

This: https://github.com/otland/forgottenserver/blob/master/src/actions.cpp#L337 sets bedItem in Player to BedItem*: https://github.com/otland/forgottenserver/blob/master/src/player.h#L226 but does not 'increase pointer' [old TFS] (or use Shared Pointer).

If it opens Dialog window and in meanwhile someone 'Wrap' BedItem (remove ite), it will crash, when someone close Dialog around that line: https://github.com/otland/forgottenserver/blob/master/src/game.cpp#L5655

Expected Behavior

Not crash.

Backtrace

No response