otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.55k stars 1.04k forks source link

Fix npc baseSpeed & build issue (AccountType_t) #4763

Closed xmish closed 5 days ago

xmish commented 6 days ago

Pull Request Prelude

Changes Proposed

forgottenserver\src\iologindata.h(22,23): error C3646: 'getAccountType': unknown override specifier
forgottenserver\src\iologindata.h(22,38): error C2275: 'uint32_t': expected an expression instead of a type
forgottenserver\src\iologindata.h(22,47): error C2146: syntax error: missing ')' before identifier 'accountId'
forgottenserver\src\iologindata.h(22,57): error C2238: unexpected token(s) preceding ';'
forgottenserver\src\iologindata.h(23,49): error C2061: syntax error: identifier 'AccountType_t'
forgottenserver\src\item.h(244,6): error C2679: binary '=': no operator found which takes a right-hand operand of type 'int64_t' (or there is no acceptable conversion)
forgottenserver\src\item.h(253,6): error C2679: binary '=': no operator found which takes a right-hand operand of type 'double' (or there is no acceptable conversion)
forgottenserver\src\item.h(262,6): error C2679: binary '=': no operator found which takes a right-hand operand of type 'bool' (or there is no acceptable conversion)
forgottenserver\src\iologindata.cpp(40,28): error C2039: 'getAccountType': is not a member of 'IOLoginData'
forgottenserver\src\iologindata.cpp(50,19): error C2511: 'void IOLoginData::setAccountType(uint32_t,AccountType_t)': overloaded member function not found in 'IOLoginData'

Issues addressed:

4760 [Bug]: NPCs custom speed attribute is ignored