otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.59k stars 1.06k forks source link

Update source, doAreaCombatHealth pos wrong #849

Closed PrinterLUA closed 10 years ago

PrinterLUA commented 10 years ago

Hello,

Ive update my source and some of the pos of the spells has gone wrong...

PrinterLUA commented 10 years ago

@marksamman I think it has todo something with this commit: https://github.com/otland/forgottenserver/commit/27cbb7fff4a616c4a1f62d89023ca1b59a4686a6

Edit: Yep as i thougt, something with protcolgame, i added back the function addMagicEffect and now the pos of spells i made are correct.

marksamman commented 10 years ago

The problem is that you are using numbers instead of predefined constants. The function also only takes 7 arguments, not 11.