otland / forgottenserver

A free and open-source MMORPG server emulator written in C++
https://otland.net
GNU General Public License v2.0
1.59k stars 1.06k forks source link

New function (configManager.setString) #896

Closed WibbenZ closed 5 months ago

WibbenZ commented 10 years ago

Well I just tought about it, why not add a function to change the string in config.lua. Ex. configManager.setString(motd, "Today is " os.date("%A"))

This would make it posible to add motds like cipsoft has, "Have a nice weekend" etc. But also things like if you are planning a longer server save its posible to do that without having to change it the day before that server save.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Nu77 commented 10 years ago

I think this is useless because "config" is a thing you only change a bit of times and if you need change that why you will change with a function ?

WibbenZ commented 10 years ago

Well I just gave you a good reason with the motd, but the same goes for double exp / skill rates aswell. Den 11 jul 2014 21:48 skrev "djayk1" notifications@github.com:

I think this is useless because "config" is a thing you only change a bit of times and if you need change that why you will change with a function ?

— Reply to this email directly or view it on GitHub https://github.com/otland/forgottenserver/issues/896#issuecomment-48774760 .

PrinterLUA commented 10 years ago

But does it not req a reload?

WibbenZ commented 10 years ago

Yes it would but that can be handled via the new code, by using g_config.reload();

zakius commented 9 years ago

First of all: I'm still for restarting server every day Second: I don't think that RELOAD is needed, just overwrite value in memory

ranisalt commented 8 years ago

Because it is not data (as in database)

ramon-bernardo commented 5 months ago

Server motd no longer exists, this can be closed.