search

otm / svg.path.js

A path extension for the svg.js library
http://otm.github.io/svg.path.js/
95 stars 32 forks source link

check package version before buildt #7

Closed dotnetCarpenter closed 10 years ago

dotnetCarpenter commented 10 years ago

This is the PR mention in #6. I also added the bower update argument ---production to svg.js. It doesn't do anything now but it might in the future and we probably never need anything but the svg.js file itself.

This PR is a cumulative PR. Let me know if you want to reject #5 and only merge the version check. Then I'll update this PR.

I've also made a feature request with https://github.com/yatskevich/grunt-bower-task/issues/103 about not copying svg.js everytime you do a grunt update. We'll see what happens. Unfortunately I don't have time to pursue this further until next week.

otm commented 10 years ago

Thanks. I will not pull the entire PR due to the diff of package.js.

Again, thanks for the PR.

dotnetCarpenter commented 10 years ago

I'm not sure what you mean. I haven't touched package.json. Other than the version number which should change upon update. I now see what you mean. package.json needs to be updated in order for this PR to work. It depends on "grunt-bower-task": "~0.3.4" for updating jsvg.js.

dotnetCarpenter commented 10 years ago

Is it a problem? I'll happily create another PR with the stuff you want to merge

otm commented 10 years ago

Please create a new. Don't like diffs for no reason when it's not needed. On 5 Feb 2014 18:47, "Jon Ege Ronnenberg" notifications@github.com wrote:

Is it a problem? I'll happily create another PR with the stuff you want to merge

Reply to this email directly or view it on GitHubhttps://github.com/otm/svg.path.js/pull/7#issuecomment-34216429 .

dotnetCarpenter commented 10 years ago

Just to be sure, you mean the version bump?

dotnetCarpenter commented 10 years ago

Merge #8 instead