search

otr4j / otr4j-issues

1 stars 0 forks source link

SMPTests takes about 10 minutes to run #14

Closed languitar closed 4 years ago

languitar commented 9 years ago

When executing the test suite, SMP test seems to block indefinitely in my case. The main thread gets stuck in bobLock.await(2000, TimeUnit.MILLISECONDS); line 77.

eighthave commented 9 years ago

I've run these tests a lot, albeit basically only on my laptop, and I've never had it hang. Can you give more info, like turning on logging to FINEST and seeing where it hangs?

languitar commented 9 years ago

Or maybe, is it intended that takes more than one minute? After that I gave up.

eighthave commented 9 years ago

ah, well, ideally it would not take a long time to run, but the whole test suite does requires something like 5-10 minutes. For now, I just got it working, in the future we can look at speeding it up.

languitar commented 9 years ago

Ouch ok... that wasn't expected.

eighthave commented 9 years ago

its not just a single test, it runs through a lot of variations of unicode and special characters in the SMP process to make sure the edge cases are working.

eighthave commented 9 years ago

For example, these tests uncovered otr4j-temp/otr4j-issues#10

eighthave commented 9 years ago

and the null issue I fixed in 45ebefa8b8154599c25d808318ac4b2a91b523d5

languitar commented 9 years ago

Maybe it would be a good idea to use a junit parametrized test so that at least some progress is visible for the individual test cases: https://github.com/junit-team/junit/wiki/Parameterized-tests

eighthave commented 9 years ago

I think this is handled for now, so I'm closing it.