search

otr4j / otr4j-issues

1 stars 0 forks source link

AuthContext.localDHPrivateKeyID is hardcoded to 1 #3

Closed eighthave closed 4 years ago

eighthave commented 9 years ago

Looks like AuthContextImpl.localDHPrivateKeyID is only ever hardcoded to 1. or am I missing something? Does that variable still need to be exposed in things like the contructors for SignatureM and SignatureX? It seems that field is entirely pointless because it is always 1.

cobratbq commented 9 years ago

It looks like that to me. Key rotation happens in another part of the code. I think this is only used for the first message. According to the spec, it does not have to be "1" per se. It is just a number chosen to be used as a serial number.