search

otringal / MB-userscripts

5 stars 1 forks source link

Drop recording merge page support #7

Closed jesus2099 closed 1 year ago

jesus2099 commented 1 year ago

... as it is now part of MBS: https://tickets.metabrainz.org/browse/MBS-2768 https://github.com/metabrainz/musicbrainz-server/pull/1586

If we keep this code, we have a duplicate AcoustID column.

otringal commented 1 year ago

Hi! Sorry for the late reply, I've been busy the last few weeks with various things and didn't have time to look into this. Thanks for the ping though, I was going to look into this last weekend but forgot. The reason why I didn't remove it myself is because I remember that the script stopped working on that page after the update that you mentioned, but something must have changed because now it works again (I guess that's why you noticed it). I think we both can agree that he official solution looks much worse than mine. I had some ideas to update my script so that it instead makes MB's own AcoustID list collapsible and perhaps also removes the AcoustIDs that has "line-through" from the visible list. But that requires new code so no harm in removing it completely from that page for now.

Thanks for fixing!

jesus2099 commented 1 year ago

the official solution looks much worse

Oh I don't remember. I've been seeing that duplicate column for a quote long time but thought they were really identical. I'll try again and compare. Now we can make PR on MBS to improve it! 😉