search

otrv4 / libotr-ng

A new implementation of OTR with support for version 4. This is a mirror of https://bugs.otr.im/otrv4/libotr-ng
Other
43 stars 9 forks source link

Make failure text on query message translatable #169

Closed claucece closed 5 years ago

claucece commented 5 years ago

As seen here: https://github.com/otrv4/libotr-ng/blob/master/src/client.c#L274

  if (otrng_failed(otrng_build_query_message(&ret, msg, conv->conn))) {
    // TODO: @client This should come from the client (a callback maybe?)
    // because it knows in which language this should be sent, for example.
    char *error = otrng_xstrdup(
        "Failed to start an Off-the-Record private conversation.");
    return error;
  }
claucece commented 5 years ago

We should probably and mostly use a callback for this.

olabini commented 5 years ago

This should be simple to sort out.