Check that Old Mac keys are correctly revealed - Githubissues

otrv4 / libotr-ng

A new implementation of OTR with support for version 4. This is a mirror of https://bugs.otr.im/otrv4/libotr-ng

Other

43 stars 9 forks source link

Check that Old Mac keys are correctly revealed #82

Closed claucece closed 6 years ago

claucece commented 6 years ago

Why

As we are currently implementing the revision number 2 of the OTRv4 specification, we need to include a consistent way of revealing MAC keys.

Reference

Please, refer to the "Revealing MAC keys" section of the OTRv4 spec.

Tasks

[x] Check that the list of the old mac keys is correctly set up.
[x] Check that all old mac keys are included in the appropriate list.
[x] Check that TLV type 1 reveals some MAC keys.
[x] Reveal MAC keys of skipped stored messages keys.
[x] Check that MAC keys are derived from the message key.
[x] Correctly derive the MAC keys for the non-interactive DAKE.

Open questions

None.

claucece commented 6 years ago

This issue is basically solved, but is waiting on the double ratchet in out-of-order, to derive the old mac keys of stored messages.