search

otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

Turning off OTR for a peer causes bad behavior #43

Open olabini opened 6 years ago

olabini commented 6 years ago

If you inside of Pidgin says that OTR is turned off for ONE peer, you get weird behavior, primarily that someone starting an OTR conversation from the other side, still seems able to do it.

olabini commented 5 years ago

I'll take a look at this one.

claucece commented 5 years ago

Doing some investigation, it turns out that this happens:

Assertion failed: (client->client_profile != NULL), function otrng_client_get_client_profile, file client.c, line 833.

and, then, pidgin crashes.

pedropalau commented 5 years ago 
Assertion failed: (client->client_profile != NULL), function otrng_client_get_client_profile, file client.c, line 833.

This happens also when the server is not configured well.

I found this bug with @Cris2760 when we was reviewing another issue.

claucece commented 5 years ago

Yeah, it is caused by this: https://github.com/otrv4/pidgin-otrng/issues/107 The publication is not handled in the best way when locally something is not changed.