search

otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

Crash at start #76

Closed claucece closed 5 years ago

claucece commented 5 years ago

Due to some recent additions (apparently because of orchestration), pidgin will crash when there is previously no persisted files. 

(22:58:25) jabber: jabber_actions: have pep: YES
otrng_client_ensure_correct_state()
orchestration.load_long_term_keys_from_storage
orchestration.create_long_term_keys
(22:58:26) dnssrv: res_query returned an error
(22:58:26) jabber: got 0 SRV responses for STUN.
orchestration.create_long_term_keys
Pidgin 2.12.0 has segfaulted and attempted to dump a core file.
claucece commented 5 years ago

cc./ @olabini @giovaneliberato

olabini commented 5 years ago

OK, so I have now fixed this with the current version of libotr-ng and pidgin-otrng. However, in order to fix it I had to comment out a line that read otrng_prekey_client_set_client_profile_publication(client->prekey_client) inside of profiles_create_client_profile, since there is no guarantee a prekey_client will exist at the time this function is called. @giovaneliberato - we need to retain the other methods for publishing client profiles and other things until the new functionality works.