search

otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

The prekey profile is sometimes wrong when publishing #78

Closed olabini closed 6 years ago

olabini commented 6 years ago

It seems the instance tag is incorrect

olabini commented 6 years ago

OK, this seems to be because the prekey client plugins are using one static callback field, and this callback struct also contains the ctx to use. However, in get_prekey_client_for_sending_offline_message the ctx part of the struct gets modified. Thus, this will ALWAYS have problems for the prekey work. I'll have to rethink how all this fits together to fix this problem.

olabini commented 6 years ago

Opened #82 to track this. I'll keep this open until I can verify that #82 fixes this problem.

olabini commented 6 years ago

This has been temporarily fixed in libotr-ng by copying the callbacks. The real solution is #82 though.