search

otrv4 / pidgin-otrng

Fork of https://bugs.otr.im/plugins/pidgin-otr. This is a mirror of https://bugs.otr.im/otrv4/pidgin-otrng
GNU General Public License v2.0
16 stars 5 forks source link

Another crash in client profile serialization #81

Closed olabini closed 5 years ago

olabini commented 5 years ago 
               #0  0x00007f9388e8ceab raise (libc.so.6)
                #1  0x00007f9388e775b9 abort (libc.so.6)
                #2  0x000055ca069861be sighandler (pidgin)
                #3  0x00007f9388e8cf30 __restore_rt (libc.so.6)
                #4  0x00007f9388fb27c1 __strlen_avx2 (libc.so.6)
                #5  0x00007f937245929a otrng_client_profile_serialize (libotr-ng.so.0)
                #6  0x00007f937246b01b otrng_prekey_dake2_message_valid (libotr-ng.so.0)
                #7  0x00007f937246c992 process_received_dake2 (libotr-ng.so.0)
                #8  0x00007f937246ca3a receive_dake2 (libotr-ng.so.0)
                #9  0x00007f937246d31a receive_decoded (libotr-ng.so.0)
                #10 0x00007f937246d47c otrng_prekey_client_receive (libotr-ng.so.0)
                #11 0x00007f937268e94c otrng_plugin_receive_prekey_protocol_message (pidgin-otrng.so)
                #12 0x00007f938bcaed1b purple_marshal_INT__POINTER_POINTER_POINTER_POINTER_POINTER (libpurple.so.0)
                #13 0x00007f938bcadfc6 purple_signal_emit_vargs_return_1 (libpurple.so.0)
                #14 0x00007f938bcae132 purple_signal_emit_return_1 (libpurple.so.0)
                #15 0x00007f938bcac636 serv_got_im (libpurple.so.0)
                #16 0x00007f936dbfebd7 jabber_message_parse (libjabber.so.0)

Probably related to #80

olabini commented 5 years ago

Fixed by making key generation not re-entrant.